git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH RFC v2] builtin-push: add --delete as syntactic sugar for :foo

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 29, 2009, 16:58 UTC
Message-ID
<7vvdfpg1je.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091229200523.6117@nanako3.lavabit.com>
Nanako Shiraishi <nanako3@lavabit.com> writes:
Show 6 quoted lines
> Junio, could you tell us what happened to this thread?
>
> The patch implements "git push repo --delete branch" and rejects
> --delete used with other options like --all and --tags, as suggested in
> the initial review.  I think it makes sense, but nothing happens after
> that.

Sverre cited an old discussion and the discussion stalled. I just re-read the thread, and think the "this is a wrong idea" objection was primarily about allowing --delete with non-delete kinds of refspecs, so in that sense Jan's patch is a perfected form of the Sverre's patch from that old discussion.

As a summary of the lesson learned and concensus from the old discussion, I agree with this from Sverre:

  http://article.gmane.org/gmane.comp.version-control.git/125901

namely, (1) barf and abort if src:dst is given; (2) touch only refs given from the command line, "push there --delete" without any refspec is an error; (3) be careful about "git push there tag v1.0.0" form.

So if Jan or Sverre want to resurrect the topic, I am all for it.
Previous: Nanako ShiraishiNext: Jan Krüger
Message 7 of 11 in “builtin-push: add --delete as syntactic sugar for :foo”
  1. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Nov 9, 2009
  2. Junio C HamanoNov 9, 2009
  3. Junio C HamanoNov 9, 2009
  4. Sverre RabbelierNov 9, 2009
  5. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Nov 9, 2009
  6. Nanako ShiraishiDec 29, 2009
  7. Junio C HamanoDec 29, 2009
  8. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Dec 30, 2009
  9. Sverre RabbelierDec 30, 2009
  10. Junio C HamanoDec 30, 2009
  11. builtin-push: add --delete as syntactic sugar for :fooJan Krüger, Dec 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.