Re: [PATCH 3/3] show: turn on rename progress

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2011, 21:25 UTC
Message-ID: <7vvcz9cyxd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110323181915.GC17533@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> For large commits, it is nice to have some eye candy for the
> rename detection.
>
> This makes sense for "show", which is showing a single diff,
> since the progress reporting will be shown before the pager
> shows any output.
>
> We don't want to do the same for "log", though, because the
> progress would be interspersed with the various commits.

I understand that you said q&d, but these days since f222abd (Make 'git show' more useful, 2009-07-13), show does walk when it is asked to.

"git show master maint" will also be affected with this, no?

Show 18 quoted lines

>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  builtin/log.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/builtin/log.c b/builtin/log.c
> index 707fd57..cf68130 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -416,6 +416,7 @@ int cmd_show(int argc, const char **argv, const char *prefix)
>  	rev.diff = 1;
>  	rev.always_show_header = 1;
>  	rev.no_walk = 1;
> +	rev.diffopt.show_rename_progress = 1;
>  	memset(&opt, 0, sizeof(opt));
>  	opt.def = "HEAD";
>  	opt.tweak = show_rev_tweak_rev;