Re: [PATCH 3/3] show: turn on rename progress

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2011, 23:03 UTC
Message-ID: <7v4o6s86kr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110324174556.GA30661@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 20 quoted lines

> On Thu, Mar 24, 2011 at 08:00:38AM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > On Wed, Mar 23, 2011 at 02:25:02PM -0700, Junio C Hamano wrote:
>> >
>> > We could also turn it on for "git log" in that case, though it is only
>> > useful if the first commit happens to be the one that is slow.
>> >
>> > I should also turn it on for "git diff". I'll prepare a cleaner series
>> > with that in it, too.
>> 
>> Sounds good, thanks.
>
> Here it is:
>
>   [1/4]: pager: save the original stderr when redirecting to pager
>   [2/4]: progress: use pager's original_stderr if available
>   [3/4]: show: turn on rename detection progress reporting
>   [4/4]: diff: turn on rename detection progress reporting

Thanks, but why does it affect t0101 and many others...?

t/jk/progress-with-pager$ sh t0101-at-syntax.sh -i -v
Initialized empty Git repository in /git/git.git/t/trash
directory.t0101-at-syntax/.git/
expecting success: 
        test_commit one &&
        test_commit two

[master (root-commit) d79ce16] one
 Author: A U Thor <author@example.com>
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 one.t
[master 139b20d] two
 Author: A U Thor <author@example.com>
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 two.t
ok 1 - setup

expecting success: 
        check_at @{0} two

--- expect 2011-03-24 22:59:09.000000000 +0000 +++ actual 2011-03-24 22:59:09.000000000 +0000

@@ -1 +1,2 @@
 two
+one
not ok - 2 @{0} shows current
#
#               check_at @{0} two
#