Re: [PATCH 3/3] show: turn on rename progress

From: Jeff King <peff@peff.net>
Date: Mar 24, 2011, 17:45 UTC
Message-ID: <20110324174556.GA30661@sigill.intra.peff.net>
In-Reply-To: <7v39mca7hl.fsf@alter.siamese.dyndns.org>

On Thu, Mar 24, 2011 at 08:00:38AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > On Wed, Mar 23, 2011 at 02:25:02PM -0700, Junio C Hamano wrote:
> >
> > We could also turn it on for "git log" in that case, though it is only
> > useful if the first commit happens to be the one that is slow.
> >
> > I should also turn it on for "git diff". I'll prepare a cleaner series
> > with that in it, too.
> 
> Sounds good, thanks.

Here it is:

  [1/4]: pager: save the original stderr when redirecting to pager
  [2/4]: progress: use pager's original_stderr if available
  [3/4]: show: turn on rename detection progress reporting
  [4/4]: diff: turn on rename detection progress reporting

Show 8 quoted lines

> > What about the degrade-cc-to-c warnings? Are you working on another
> > revision, or should I re-roll your changes on top of my series, handling
> > the "one-warning-per-commit" behavior I suggested when stdout and stderr
> > are combined?
> 
> Also sounds good, thanks.  No, I am spending far more time on ushering
> stalled topics than looking at my weatherbaloons and no time left for the
> latter.

I thought this would be simple on top of 1/4 above, but it's not. In some cases we want to insert the warning before the diff output, and in some cases we want to know afterwards what happened. Which means we probably need to carry a new "show the warning" flag in diffopt and respect it in the rename, but also fill out the needed_rename_limit.

-Peff