Re: [PATCH] HOME must be set before calling git-init when creating test repositories

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 25, 2011, 22:39 UTC
Message-ID: <7vvcz64ygm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTikO4=TtFtpsQ_JtmGKqQ1NzgTuo7e8cdaQca+T7@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 19 quoted lines

> On Fri, Mar 25, 2011 at 22:30, Junio C Hamano <gitster@pobox.com> wrote:
>> Alex Riesen <raa.lkml@gmail.com> writes:
>>
>>> On Fri, Mar 25, 2011 at 21:49, Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>>> Doesn't this change the location of HOME used during the test as well?
>>>
>>> As long as the test only includes test-lib.sh only once - it doesn't.
>>> Why? Or rather, how?
>>
>> I thought you moved HOME=$(pwd) across "cd somewhere-else".  Doesn't it
>> change what is returned from pwd?
>>
>
> Oh, it does. That's why the second patch (prefixed "[PATCH, fixed]").
> It makes HOME to be "$(pwd)/somewhere-else", or precisely:
>
>   HOME="$(pwd)"/"$test"
>   export HOME

What happens to people who has non-empty "$root", iow, their $test begins with '/'?

I am not saying that having HOME at t/ directory instead of t/trash-*/ directory would necessarily break things (I don't know). I am just pointing out that the patch changes behaviour.