git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] HOME must be set before calling git-init when creating test repositories

From
Jeff King <peff@peff.net>
Date
Mar 26, 2011, 18:31 UTC
Message-ID
<20110326183102.GA3796@sigill.intra.peff.net>
In-Reply-To
<20110326182126.GA13496@blimp.localdomain>
On Sat, Mar 26, 2011 at 07:21:26PM +0100, Alex Riesen wrote:
Show 7 quoted lines
> > No, it's totally broken. $(pwd)/$test is nonsensical. The code right
> > above your change guarantees that $test is an absolute path, either
> > because the user gave us an absolute $root or because it has been
> > prepended with $TEST_DIRECTORY (which itself comes from $(pwd)).
> 
> I see. I mistook "$root" for the root of a filesystem, not the variable in
> test-lib.sh. How about this, than?

Oops, when I said "$test" I meant to say $TRASH_DIRECTORY. That is, $TRASH_DIRECTORY is always the absolute path to the trash.

> +HOME="$(pwd)/$test"
> +test -n "$root" && HOME="$test"
> +export HOME
So you can simplify this to just:
HOME=$TRASH_DIRECTORY
and not have to worry about checking $root at all.
Sorry for the confusion.
-Peff
Previous: Alex RiesenNext: Alex Riesen
Message 11 of 14 in “HOME must be set before calling git-init when creating test repositories”
  1. HOME must be set before calling git-init when creating test repositoriesAlex Riesen, Mar 25, 2011
  2. HOME must be set before calling git-init when creating test repositoriesAlex Riesen, Mar 25, 2011
  3. Junio C HamanoMar 25, 2011
  4. Alex RiesenMar 25, 2011
  5. Junio C HamanoMar 25, 2011
  6. Alex RiesenMar 25, 2011
  7. Junio C HamanoMar 25, 2011
  8. Alex RiesenMar 26, 2011
  9. Jeff KingMar 26, 2011
  10. HOME must be set before calling git-init when creating test repositoriesAlex Riesen, Mar 26, 2011
  11. Jeff KingMar 26, 2011
  12. Alex RiesenMar 26, 2011
  13. HOME must be set before calling git-init when creating test repositoriesAlex Riesen, Mar 26, 2011
  14. Jeff KingMar 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.