Re: [PATCH] HOME must be set before calling git-init when creating test repositories

From: Jeff King <peff@peff.net>
Date: Mar 26, 2011, 18:48 UTC
Message-ID: <20110326184806.GA4488@sigill.intra.peff.net>
In-Reply-To: <20110326184634.GB13496@blimp.localdomain>

On Sat, Mar 26, 2011 at 07:46:34PM +0100, Alex Riesen wrote:

Show 19 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 7cc9a52..7965b74 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -984,14 +984,14 @@ rm -fr "$test" || {
>  	exit 1
>  }
>  
> +HOME="$TRASH_DIRECTORY"
> +export HOME
> +
>  test_create_repo "$test"
>  # Use -P to resolve symlinks in our working directory so that the cwd
>  # in subprocesses like git equals our $PWD (for pathname comparisons).
>  cd -P "$test" || exit 1
>  
> -HOME=$(pwd)
> -export HOME
> -

That looks right to me. Thanks.

-Peff