git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix compilation on newer NetBSD systems

From
Junio C Hamano <junkio@cox.net>
Date
May 15, 2006, 05:31 UTC
Message-ID
<7vu07rx3a9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060511173531.G18d4553c@leonov.stosberg.net>
Dennis Stosberg <dennis@stosberg.net> writes:
> NetBSD >=2.0 has iconv() in libc.  A libiconv is not required and
> does not exist.
I do not doubt that, but...
> +	ifeq ($(shell test `uname -r | sed -e 's/^\([0-9]\).*/\1/'` -lt 2 && echo y),y)
> +		NEEDS_LIBICONV = YesPlease
> +	endif

This looks rather ugly. I do not know if NetBSD has 0.xx versions, but perhaps something like this?

	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)
Previous: Dennis StosbergNext: Dennis Stosberg
Message 2 of 3 in “Fix compilation on newer NetBSD systems”
  1. Fix compilation on newer NetBSD systemsDennis Stosberg, May 11, 2006
  2. Junio C HamanoMay 15, 2006
  3. Dennis StosbergMay 15, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.