Re: [PATCH] Fix compilation on newer NetBSD systems

From: Dennis Stosberg <dennis@stosberg.net>
Date: May 15, 2006, 12:41 UTC
Message-ID: <20060515124115.G78828137@leonov.stosberg.net>
In-Reply-To: <7vu07rx3a9.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 10 quoted lines

> Dennis Stosberg <dennis@stosberg.net> writes:
> 
> > +	ifeq ($(shell test `uname -r | sed -e 's/^\([0-9]\).*/\1/'` -lt 2 && echo y),y)
> > +		NEEDS_LIBICONV = YesPlease
> > +	endif
> 
> This looks rather ugly.  I do not know if NetBSD has 0.xx
> versions, but perhaps something like this?
> 
> 	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)

Admittedly, that looks a lot nicer. And it works correctly with NetBSD's "expr", too.

Regards, Dennis