From: Junio C Hamano <junkio@cox.net>
Date: Mon, 15 May 2006 05:31:10 GMT
Subject: Re: [PATCH] Fix compilation on newer NetBSD systems
Message-ID: <7vu07rx3a9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060511173531.G18d4553c@leonov.stosberg.net>

Dennis Stosberg <dennis@stosberg.net> writes:

> NetBSD >=2.0 has iconv() in libc.  A libiconv is not required and
> does not exist.

I do not doubt that, but...

> +	ifeq ($(shell test `uname -r | sed -e 's/^\([0-9]\).*/\1/'` -lt 2 && echo y),y)
> +		NEEDS_LIBICONV = YesPlease
> +	endif

This looks rather ugly.  I do not know if NetBSD has 0.xx
versions, but perhaps something like this?

	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)