git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] git-tag: fix -l switch handling regression.

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 17, 2007, 20:13 UTC
Message-ID
<7vtzmh6pwn.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071217190328.GF22554@artemis.madism.org>
Pierre Habouzit <madcoder@debian.org> writes:
Show 19 quoted lines
> On Mon, Dec 17, 2007 at 06:56:52PM +0000, Pierre Habouzit wrote:
>>   And I managed to resend the broken version, hurray myself.
>> 
>> > +		OPT_INTEGER('l', NULL, &list, "list tag names"),
>>                 OPT_BOOLEAN
>> 
>> 
>> 
>> Both these last minute fixes are applied to my public git.git.
>> 
>> Let's now write 1000 times: I will run the test-suite before I send
>> patches, I will rune the test-suite before I send patches, …
>
>   oh and t7004 doesn't pass anymore because of the:
>
>   git -n xxx -l or git -n "" -l tests. If we really want to allow that
> (but it _REALLY_ feels wrong to me) we have to make '-l' a callback that
> groks non integers as 0. Else the test also has to be fixed, I'm not
> sure what to do here.

I did not understand what "git tag -n xxx" was meant to do, either. Time to run blame and ask the responsible party?

I suspect "-n ''" there might be meant as a way to spell the "no argument here -- use our default" instruction. It looks slightly nicer than that '{}' but not quite.

Previous: Pierre HabouzitNext: Wayne Davison
Message 11 of 13 in “[proposal] make parse-options nicer wrt optional arguments (supersedes all my recent posts on the matter)”
  1. Pierre HabouzitDec 17, 2007
  2. 1/7 parse-options: Make callbacks take flags instead of boolean `unset`Pierre Habouzit, Dec 17, 2007
  3. 2/7 parse-options: allow callbacks to ignore arguments they don't need to use.Pierre Habouzit, Dec 17, 2007
  4. 3/7 parse-options: Let the integer/string cases be callbacks as well.Pierre Habouzit, Dec 17, 2007
  5. 4/7 parse-options: let OPT__ABBREV ignore arguments.Pierre Habouzit, Dec 17, 2007
  6. 5/7 parse-options: Add a gitcli(5) man page.Pierre Habouzit, Dec 17, 2007
  7. 6/7 parse-options: have a `use default value` wildcard.Pierre Habouzit, Dec 17, 2007
  8. 7/7 git-tag: fix -l switch handling regression.Pierre Habouzit, Dec 17, 2007
  9. Pierre HabouzitDec 17, 2007
  10. Pierre HabouzitDec 17, 2007
  11. Junio C HamanoDec 17, 2007
  12. Wayne DavisonDec 18, 2007
  13. Pierre HabouzitDec 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.