git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/7] parse-options: let OPT__ABBREV ignore arguments.

From
Pierre Habouzit <madcoder@debian.org>
Date
Dec 17, 2007, 18:23 UTC
Message-ID
<1197915797-30679-5-git-send-email-madcoder@debian.org>
In-Reply-To
<1197915797-30679-4-git-send-email-madcoder@debian.org>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 parse-options.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/parse-options.c b/parse-options.c
index f3f0f2a..679a963 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -359,19 +359,21 @@ void usage_with_options(const char * const *usagestr,
 
 int parse_opt_abbrev_cb(const struct option *opt, const char *arg, int flags)
 {
-	int v;
-
-	if (!arg) {
-		v = flags & PARSE_OPT_UNSET ? 0 : DEFAULT_ABBREV;
-	} else {
+	int v = flags & PARSE_OPT_UNSET ? 0 : DEFAULT_ABBREV;
+	if (arg) {
 		v = strtol(arg, (char **)&arg, 10);
-		if (*arg)
+		if (*arg) {
+			if (flags & PARSE_OPT_MAY_IGN) {
+				*(int *)opt->value = DEFAULT_ABBREV;
+				return PARSE_OPT_IGNORE;
+			}
 			return opterror(opt, "expects a numerical value", 0);
+		}
 		if (v && v < MINIMUM_ABBREV)
 			v = MINIMUM_ABBREV;
 		else if (v > 40)
 			v = 40;
 	}
-	*(int *)(opt->value) = v;
+	*(int *)opt->value = v;
 	return 0;
 }
-- 
1.5.4.rc0.1148.ga3ab1-dirty
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 5 of 13 in “[proposal] make parse-options nicer wrt optional arguments (supersedes all my recent posts on the matter)”
  1. Pierre HabouzitDec 17, 2007
  2. 1/7 parse-options: Make callbacks take flags instead of boolean `unset`Pierre Habouzit, Dec 17, 2007
  3. 2/7 parse-options: allow callbacks to ignore arguments they don't need to use.Pierre Habouzit, Dec 17, 2007
  4. 3/7 parse-options: Let the integer/string cases be callbacks as well.Pierre Habouzit, Dec 17, 2007
  5. 4/7 parse-options: let OPT__ABBREV ignore arguments.Pierre Habouzit, Dec 17, 2007
  6. 5/7 parse-options: Add a gitcli(5) man page.Pierre Habouzit, Dec 17, 2007
  7. 6/7 parse-options: have a `use default value` wildcard.Pierre Habouzit, Dec 17, 2007
  8. 7/7 git-tag: fix -l switch handling regression.Pierre Habouzit, Dec 17, 2007
  9. Pierre HabouzitDec 17, 2007
  10. Pierre HabouzitDec 17, 2007
  11. Junio C HamanoDec 17, 2007
  12. Wayne DavisonDec 18, 2007
  13. Pierre HabouzitDec 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.