git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] git-tag: fix -l switch handling regression.

From
Pierre Habouzit <madcoder@debian.org>
Date
Dec 17, 2007, 18:23 UTC
Message-ID
<1197915797-30679-8-git-send-email-madcoder@debian.org>
In-Reply-To
<1197915797-30679-7-git-send-email-madcoder@debian.org>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 builtin-tag.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/builtin-tag.c b/builtin-tag.c
index fd44b2e..c7a1563 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -16,7 +16,7 @@
 static const char * const git_tag_usage[] = {
 	"git-tag [-a|-s|-u <key-id>] [-f] [-m <msg>|-F <file>] <tagname> [<head>]",
 	"git-tag -d <tagname>...",
-	"git-tag [-n [<num>]] -l [<pattern>]",
+	"git-tag -l [-n [<num>]] [<pattern>]",
 	"git-tag -v <tagname>...",
 	NULL
 };
@@ -370,13 +370,11 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 	struct ref_lock *lock;
 
 	int annotate = 0, sign = 0, force = 0, lines = 0,
-					delete = 0, verify = 0;
-	char *list = NULL, *msgfile = NULL, *keyid = NULL;
-	const char *no_pattern = "NO_PATTERN";
+		list = 0, delete = 0, verify = 0;
+	char *msgfile = NULL, *keyid = NULL;
 	struct msg_arg msg = { 0, STRBUF_INIT };
 	struct option options[] = {
-		{ OPTION_STRING, 'l', NULL, &list, "pattern", "list tag names",
-			PARSE_OPT_OPTARG, NULL, (intptr_t) no_pattern },
+		OPT_INTEGER('l', NULL, &list, "list tag names"),
 		{ OPTION_INTEGER, 'n', NULL, &lines, NULL,
 				"print n lines of each tag message",
 				PARSE_OPT_OPTARG, NULL, 1 },
@@ -408,7 +406,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 		annotate = 1;
 
 	if (list)
-		return list_tags(list == no_pattern ? NULL : list, lines);
+		return list_tags(argv[0], lines);
 	if (delete)
 		return for_each_tag_name(argv, delete_tag);
 	if (verify)
-- 
1.5.4.rc0.1148.ga3ab1-dirty
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 8 of 13 in “[proposal] make parse-options nicer wrt optional arguments (supersedes all my recent posts on the matter)”
  1. Pierre HabouzitDec 17, 2007
  2. 1/7 parse-options: Make callbacks take flags instead of boolean `unset`Pierre Habouzit, Dec 17, 2007
  3. 2/7 parse-options: allow callbacks to ignore arguments they don't need to use.Pierre Habouzit, Dec 17, 2007
  4. 3/7 parse-options: Let the integer/string cases be callbacks as well.Pierre Habouzit, Dec 17, 2007
  5. 4/7 parse-options: let OPT__ABBREV ignore arguments.Pierre Habouzit, Dec 17, 2007
  6. 5/7 parse-options: Add a gitcli(5) man page.Pierre Habouzit, Dec 17, 2007
  7. 6/7 parse-options: have a `use default value` wildcard.Pierre Habouzit, Dec 17, 2007
  8. 7/7 git-tag: fix -l switch handling regression.Pierre Habouzit, Dec 17, 2007
  9. Pierre HabouzitDec 17, 2007
  10. Pierre HabouzitDec 17, 2007
  11. Junio C HamanoDec 17, 2007
  12. Wayne DavisonDec 18, 2007
  13. Pierre HabouzitDec 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.