Re: git status in clean working dir

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2008, 02:40 UTC
Message-ID: <7vtzeir68z.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vy73ur6pz.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

>> git status -a 
>>
>> exits with 0
>> ...
>
> Try "git status -a >/dev/null" or "git --no-pager status -a".
>
> I think this is an instance of the c8af1de (make git-status use a pager,
> 2008-04-23) stupidity raising its ugly head again.
>
> Do people mind reverting that patch?

Actually, the situation is now even worse than I originally thought especially with Jeff's pager.<cmd> patch on 'master' recently. For example, you can screw yourself quite badly by forcing diff-files used in the scripts you run to page, defeating --exit-code option. Which means

 (1) It hurts?  Don't do it then; but

 (2) Then why are we even allowing to configure the plumbing to page?

Should we maintain a table of commands that we allow paging to be customized, and ignore pager.<cmd> for commands that are not in the list?

Which codepath should issue error messages when the user tries to break the system by saying "pager.diff-files = true"?