Re: [PATCH 2/2] spawn pager via run_command interface
On Tue, Jul 22, 2008 at 07:16:30AM +0000, Jeff King wrote:
Show 13 quoted lines
> On Tue, Jul 22, 2008 at 03:14:12AM -0400, Jeff King wrote:
>
> > static struct child_process pager_process = {
> > .argv = pager_argv,
> > - .in = -1
> > + .in = -1,
> > +#ifndef __MINGW32__
> > + .preexec_cb = pager_preexec,
> > +#endif
>
> I couldn't recall if this initializer style is portable enough for us.
> It was already there wrapped in ifdefs, but perhaps it was only ok
> because the mingw version always uses the same compiler? it's not, I asked long time ago, and it's C99, which mingw supports
indeed, and we don't want to require a C99 compiler.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>