Re: [PATCH 2/2] spawn pager via run_command interface
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jul 22, 2008, 07:48 UTC
- Message-ID
- <488590B9.1080804@viscovery.net>
- In-Reply-To
- <20080722071630.GA3669@sigill.intra.peff.net>
Jeff King schrieb:
Show 13 quoted lines
> On Tue, Jul 22, 2008 at 03:14:12AM -0400, Jeff King wrote:
>
>> static struct child_process pager_process = {
>> .argv = pager_argv,
>> - .in = -1
>> + .in = -1,
>> +#ifndef __MINGW32__
>> + .preexec_cb = pager_preexec,
>> +#endif
>
> I couldn't recall if this initializer style is portable enough for us.
> It was already there wrapped in ifdefs, but perhaps it was only ok
> because the mingw version always uses the same compiler?Yes, that's because on mingw we know that we use gcc. This really must be changed for portability.
BTW, you could remove the #ifndef __MINGW32__ around both the definition and the use of pager_preexec. We have everything on mingw to compile and link this function.
-- Hannes