Re: What's cooking in git.git (Nov 2008, #06; Wed, 26)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 28, 2008, 02:06 UTC
Message-ID: <7vtz9s8uzu.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0811272347010.30769@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

> I have a strong suspicion that the narrow stuff will make the worktree 
> mess pale in comparison.
>
> Note that I do not have time to review this myself (which is not helped at 
> all by it being no longer a trivial single patch, but a full 10 patches!), 
> but I really have a bad feeling about this.  IMO it is substantially 
> under-reviewed.

Well, "a bad feeling" is not a convincing enough argument either, is it? What kind of bad interaction are you fearing?

I thought the changes this first half of the topic implements were safe for people who do not use this feature at all (which is the most important thing I care about very first), and also I thought they made sense.

A bigger concern I actually have about this series is that the original author seems to have gone quiet. I would have expected a discussion on adding Porcelain level support after the series hit 'next' to begin, so that the underlying feature can be made more accessible by the end users. Also a new section to tutorial or a new addition to how-to series of documents that describe how to work inside narrowly checked out work tree, what the pitfalls are, etc., together with follow-up improvements of what is already in 'next', and end user questions and reports on issues should have come, if this is ever being used by anybody by now, but none of that has happened.