Re: [PATCH] request-pull: do not paginate output of git commands
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 30, 2009, 18:28 UTC
- Message-ID
- <7vtz1x7f05.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1246361606-20457-1-git-send-email-mmarek@suse.cz>
Michal Marek <mmarek@suse.cz> writes:
Show 5 quoted lines
> git request-pull called inside a terminal prints part of the output to > the terminal and other parts are piped through the pager. Fix this. > > Signed-off-by: Michal Marek <mmarek@suse.cz> > ---
Having said all that, I noticed this gem in the context in your patch.
Show 11 quoted lines
> git-request-pull.sh | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/git-request-pull.sh b/git-request-pull.sh > index a2cf5b8..b3aaded 100755 > --- a/git-request-pull.sh > +++ b/git-request-pull.sh > @@ -45,13 +45,13 @@ fi > PAGER= > export PAGER > echo "The following changes since commit $baserev:"
Looking at ff06c74 (Improve request-pull to handle non-rebased branches, 2007-05-01), it introduced these specifically to address the issue you are bringing up, but it is ineffective.
I'd suggest to replace your patch with the attached instead.
---
git-request-pull.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-request-pull.sh b/git-request-pull.sh index a2cf5b8..f86d8fd 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -42,8 +42,8 @@ if [ -z "$branch" ]; then status=1 fi -PAGER= -export PAGER +GIT_PAGER=cat +export GIT_PAGER echo "The following changes since commit $baserev:" git shortlog --max-count=1 $baserev | sed -e 's/^\(.\)/ \1/'