Re: [PATCH] request-pull: do not paginate output of git commands
- From
Michal Marek <mmarek@suse.cz>
- Date
- Jun 30, 2009, 17:26 UTC
- Message-ID
- <4A4A4AB3.8030107@suse.cz>
- In-Reply-To
- <7vskhh8yxf.fsf@alter.siamese.dyndns.org>
Junio C Hamano napsal(a):
Show 18 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> Michal Marek <mmarek@suse.cz> writes: >> >>> git request-pull called inside a terminal prints part of the output to >>> the terminal and other parts are piped through the pager. Fix this. >> Hmph, I have always thought this was meant to be a feature. >> >> That is, you run it to yourself, instead of piping it to a file or "| mail >> torvalds", in order to sanity check before you actually do the latter. >> When the request is larger than a screenful, you would want a pager while >> reviewing. > > Sorry, I take it back. > > If it _were_ a single call to a paging command what I said may make sense, > but with many separate calls to shortlog, we wouldn't know which output is > too large (and uses pager). I agree your patch makes things better.
Yes, this is what I dislike, it prints parts to the terminal and parts are paged (separately). Paging the whole output would be a nice improvement, but probably not worth the effort.
> I should have read your commit log message after finishing my coffee ;-)
:-)
Michal