Re: [PATCH] request-pull: do not paginate output of git commands

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 30, 2009, 16:32 UTC
Message-ID: <7vskhh8yxf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vws6t8zhv.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Michal Marek <mmarek@suse.cz> writes:
>
>> git request-pull called inside a terminal prints part of the output to
>> the terminal and other parts are piped through the pager. Fix this.
>
> Hmph, I have always thought this was meant to be a feature.
>
> That is, you run it to yourself, instead of piping it to a file or "| mail
> torvalds", in order to sanity check before you actually do the latter.
> When the request is larger than a screenful, you would want a pager while
> reviewing.

Sorry, I take it back.

If it _were_ a single call to a paging command what I said may make sense, but with many separate calls to shortlog, we wouldn't know which output is too large (and uses pager). I agree your patch makes things better.

I should have read your commit log message after finishing my coffee ;-)

Thanks.