git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-add--interactive: never skip files included in index

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 12, 2009, 23:42 UTC
Message-ID
<7vskdo5gdl.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091012051157.GA23007@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 20 quoted lines
> Subject: [PATCH] ls-files: excludes should not impact tracked files
>
> In all parts of git, .gitignore and other exclude files
> impact only how we treat untracked files; they should have
> no effect on files listed in the index.
>
> This behavior was originally implemented very early on in
> 9ff768e, but only for --exclude-from. Later, commit 63d285c
> accidentally caused us to trigger the behavior for
> --exclude-per-directory.
>
> This patch totally ignores excludes for files found in the
> index. This means we are reversing the original intent of
> 9ff768e, while at the same time fixing the accidental
> behavior of 63d285c. This is a good thing, though, as the
> way that 9ff768e behaved does not really make sense with the
> way exclusions are used in modern git.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
Makes sense; thanks.
> I also still think that Pauli's patch makes sense; there is no point in
> passing --exclude-standard there. It should be a no-op.
Yeah, that is also queued independent from this one.
Previous: Jeff King
Message 8 of 8 in “git-add--interactive: never skip files included in index”
  1. git-add--interactive: never skip files included in indexPauli Virtanen, Oct 10, 2009
  2. Junio C HamanoOct 11, 2009
  3. Jeff KingOct 11, 2009
  4. Junio C HamanoOct 11, 2009
  5. Jeff KingOct 12, 2009
  6. Junio C HamanoOct 12, 2009
  7. Jeff KingOct 12, 2009
  8. Junio C HamanoOct 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.