Re: [PATCH] git-add--interactive: never skip files included in index

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2009, 02:46 UTC
Message-ID: <7v63alpbwx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091012014007.GA7674@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> So now I am doubly confused. Did this feature exist, and was broken, and
> you actually fixed it in 63d285c, creating what looked like a regression
> but was actually intentional?

I do not think it was an intentional change. I _think_ the comment at the beginning of show_files() tells us quite a bit---we don't do read-dir when showing the indexed files, and I suspect that we used to rely on the fact that not doing the read-dir made exclusion mechanism a no-op. After the lazy .gitignore reading, I suspect that excluded() call started to initialize the exclude mechanism lazily, and that is how the bug was introduced, isn't it?

Regarding your patch, the loops deal with paths that are already in the index, so removing the conditional skip looks like a sane thing to do.