From: Junio C Hamano Date: Mon, 12 Oct 2009 23:42:14 GMT Subject: Re: [PATCH] git-add--interactive: never skip files included in index Message-ID: <7vskdo5gdl.fsf@alter.siamese.dyndns.org> In-Reply-To: <20091012051157.GA23007@coredump.intra.peff.net> Jeff King writes: > Subject: [PATCH] ls-files: excludes should not impact tracked files > > In all parts of git, .gitignore and other exclude files > impact only how we treat untracked files; they should have > no effect on files listed in the index. > > This behavior was originally implemented very early on in > 9ff768e, but only for --exclude-from. Later, commit 63d285c > accidentally caused us to trigger the behavior for > --exclude-per-directory. > > This patch totally ignores excludes for files found in the > index. This means we are reversing the original intent of > 9ff768e, while at the same time fixing the accidental > behavior of 63d285c. This is a good thing, though, as the > way that 9ff768e behaved does not really make sense with the > way exclusions are used in modern git. > > Signed-off-by: Jeff King > --- Makes sense; thanks. > I also still think that Pauli's patch makes sense; there is no point in > passing --exclude-standard there. It should be a no-op. Yeah, that is also queued independent from this one.