Re: [PATCH/RFC v2 06/16] t3700: sleep for 1 second, to avoid interfering with the racy code

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 6, 2012, 01:43 UTC
Message-ID: <7vsjc023sr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1344203353-2819-7-git-send-email-t.gummerer@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

> The new git racy code uses the mtime of cache-entries to smudge
> a racy clean entry, and loads the work, of checking the file-system

-ECANTPARSE.

> if the entry has really changed, off to the reader. This interferes
> with this test, because the entry is racily smudged and thus has
> mtime 0. We wait 1 second to avoid smudging the entry and getting
> correct test results.

Mild NAK, especially it is totally unclear why you even need to muck with racy-git check in the current format of the index in the first place, and even if it were necessary, it is unclear why this cannot be done with test-chmtime.

Show 17 quoted lines

> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
> ---
>  t/t3700-add.sh |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/t/t3700-add.sh b/t/t3700-add.sh
> index 874b3a6..4d70805 100755
> --- a/t/t3700-add.sh
> +++ b/t/t3700-add.sh
> @@ -184,6 +184,7 @@ test_expect_success 'git add --refresh with pathspec' '
>  	echo >foo && echo >bar && echo >baz &&
>  	git add foo bar baz && H=$(git rev-parse :foo) && git rm -f foo &&
>  	echo "100644 $H 3	foo" | git update-index --index-info &&
> +	sleep 1 &&
>  	test-chmtime -60 bar baz &&
>  	>expect &&
>  	git add --refresh bar >actual &&