git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 9/10] Remove cmd_usage() routine and re-organize the help/usage code.

From
Junio C Hamano <junkio@cox.net>
Date
Aug 3, 2006, 19:30 UTC
Message-ID
<7vr6zxpqfp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<000101c6b72a$51601a80$c47eedc1@ramsay1.demon.co.uk>
"Ramsay Jones" <ramsay@ramsay1.demon.co.uk> writes:
> In any event, I'm sorry to have broken your test,

Don't worry. My primary function while wearing the "maintainer" hat is to catch mistakes like this; even if this test breakage slipped through, it would not have been your fault but mine.

> ... I should have
> documented the changed behaviour. The change should be limited to
> a lower-case usage prefix and a change in exit code from 1 to 129.

I think both are good changes. The native usage() exits with 129 so it would be consistent for the git wrapper to exit with 129 when it gives usage message, and in lowercase.

Will take a look at your patches when I go home (I am at day-job today).

Previous: Ramsay JonesNext: Junio C Hamano
Message 5 of 7 in “Remove cmd_usage() routine and re-organize the help/usage code.”
  1. 9/10 Remove cmd_usage() routine and re-organize the help/usage code.Ramsay Jones, Aug 2, 2006
  2. Martin WaitzAug 2, 2006
  3. Junio C HamanoAug 2, 2006
  4. Ramsay JonesAug 3, 2006
  5. Junio C HamanoAug 3, 2006
  6. Junio C HamanoAug 4, 2006
  7. Ramsay JonesAug 2, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.