Re: [PATCH 9/10] Remove cmd_usage() routine and re-organize the help/usage code.

From: Junio C Hamano <junkio@cox.net>
Date: Aug 2, 2006, 18:18 UTC
Message-ID: <7v4pwvuhlo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060802132149.GG16364@admingilde.org>

Martin Waitz <tali@admingilde.org> writes:

Show 15 quoted lines

> On Wed, Aug 02, 2006 at 02:03:44AM +0100, Ramsay Jones wrote:
>>  builtin-help.c |   54
>> +++++++++++++++++++++++-------------------------------
>>  builtin.h      |    7 ++-----
>>  git.c          |    7 +++++--
>>  3 files changed, 30 insertions(+), 38 deletions(-)
>
> this patch is at the tip of "master" now, but with one more change:
>...
> diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh
> index bf1d638..34a3ccd 100755
> --- a/t/t9100-git-svn-basic.sh
> +++ b/t/t9100-git-svn-basic.sh
>...
> this looks strange.

Ramsay's patch to cmd_help() broke this test because the test relied on the details of output from "git help", which the patch subtly changed.

I considered making the fix for broken test a separate commit, but the fix for the test was simple enough, so I rolled it in, with the additional comment in the log to explain what was going on -- I suspect the explanation was not clear enough.

I could have committed the fix for the test first and then this one.