From: Junio C Hamano Date: Thu, 03 Aug 2006 19:30:50 GMT Subject: Re: [PATCH 9/10] Remove cmd_usage() routine and re-organize the help/usage code. Message-ID: <7vr6zxpqfp.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <000101c6b72a$51601a80$c47eedc1@ramsay1.demon.co.uk> "Ramsay Jones" writes: > In any event, I'm sorry to have broken your test, Don't worry. My primary function while wearing the "maintainer" hat is to catch mistakes like this; even if this test breakage slipped through, it would not have been your fault but mine. > ... I should have > documented the changed behaviour. The change should be limited to > a lower-case usage prefix and a change in exit code from 1 to 129. I think both are good changes. The native usage() exits with 129 so it would be consistent for the git wrapper to exit with 129 when it gives usage message, and in lowercase. Will take a look at your patches when I go home (I am at day-job today).