Re: [PATCH 1/2] Add git-archive

From: Junio C Hamano <junkio@cox.net>
Date: Sep 7, 2006, 08:16 UTC
Message-ID: <7vr6yo2isu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <44FFD00E.5040305@innova-card.com>

Franck Bui-Huu <vagabon.xyz@gmail.com> writes:

Show 9 quoted lines

> My first intention was to enable/disable specific archive format
> through daemon service. But we could in an other way: send a 
> "git-upload-archive --format=tar" request then in upload-archive
> check that git-upload-tar service is enabled. This service would
> exist even if git-upload-tar is not a valid command.
>
> But Rene thinks that part should be in git-upload-archive. I dunno
> what is the best direction. I have used git-daemon service because
> the service infrastucture already allow us to achieve that.

Hmph. daemon_service was a nice idea but the current implementation falls short by not giving finer control such as "this service is Ok with such and such option but not this option". Here we ideally would want to say something like "git-archive is fine with upload-tar but not upload-zip" or "Ok as long as upload-tar's numeric arg is less than 6". Needs some thought _if_ we plan to add tons of services to the daemon.

> I'm sorry to not make things faster. I'm new to git internals and
> unfortunately I'm busy to do some other (crap) things. I'll send
> a new patchset this morning and I'll sum up what's done and what
> we still need to do.

Taking things slowly is just fine. Otherwise _I_ would burn out ;-).