Re: Add git-archive [take #2]

From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sep 8, 2006, 20:21 UTC
Message-ID: <4501D0B8.8060103@lsrfire.ath.cx>
In-Reply-To: <7v8xkvqjlq.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano schrieb:

Show 16 quoted lines

> Franck Bui-Huu <vagabon.xyz@gmail.com> writes:
> 
>> I'm sending a new version of the patchset which allows 
>> 'git-archive' and 'git-upload-archive' command. I tried to take 
>> into account all feedbacks made by Junio and Rene, but there are 
>> still some open points.
>> 
>> 1/ Allow 'git-upload-archive' command to enable/disable some 
>> formats. This should be done by 'git-upload-archive'.
> 
> Perhaps.  I was thinking about the way how a site administrator can 
> configure such when upload-archive is spawned via git-daemon (for 
> users coming from ssh and spawn an upload-archive on their own, it's 
> their own process and upload-archive has no business deciding what is
>  allowed and what is forbidden).  Not very many clean ways I can
> think of unfortunately.

Mmpf, ssh is (one of the things) in my blind spot. Do you mean a ssh+git-shell connection? One could argue that since this is a restricted connection anyway upload-archive _has_ a right to restrict archive format etc., too. On a full, unrestricted ssh connection one can start git-archive directly. I'd do that anyway because I'm used to do this with tar. ;-)

Anyway, I think having config options for git-upload-archive for restricting formats and compression levels is as clean as we can get in the absence of a way for upload-archive to detect which protocol is used for the current connection. Mmh, maybe an environment variable which is set by the daemon can be used? This is no dirtier than what webservers do..

René