git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Add git-archive

From
Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Sep 6, 2006, 20:17 UTC
Message-ID
<44FF2CF1.9020201@lsrfire.ath.cx>
In-Reply-To
<cda58cb80609050516v699338b9y57fd54f50c66e49e@mail.gmail.com>
Franck Bui-Huu schrieb:
Show 50 quoted lines
> diff --git a/builtin-tar-tree.c b/builtin-tar-tree.c
> index 61a4135..e0da01e 100644
> --- a/builtin-tar-tree.c
> +++ b/builtin-tar-tree.c
> @@ -9,6 +9,7 @@ #include "strbuf.h"
> #include "tar.h"
> #include "builtin.h"
> #include "pkt-line.h"
> +#include "archive.h"
> 
> #define RECORDSIZE    (512)
> #define BLOCKSIZE    (RECORDSIZE * 20)
> @@ -338,6 +339,71 @@ static int generate_tar(int argc, const
>     return 0;
> }
> 
> +static int write_tar_entry(const unsigned char *sha1,
> +                           const char *base, int baselen,
> +                           const char *filename, unsigned mode, int stage)
> +{
> +    static struct strbuf path;
> +    int filenamelen = strlen(filename);
> +    void *buffer;
> +    char type[20];
> +    unsigned long size;
> +
> +    if (!path.alloc) {
> +        path.buf = xmalloc(PATH_MAX);
> +        path.alloc = PATH_MAX;
> +        path.len = path.eof = 0;
> +    }
> +    if (path.alloc < baselen + filenamelen) {
> +        free(path.buf);
> +        path.buf = xmalloc(baselen + filenamelen);
> +        path.alloc = baselen + filenamelen;
> +    }
> +    memcpy(path.buf, base, baselen);
> +    memcpy(path.buf + baselen, filename, filenamelen);
> +    path.len = baselen + filenamelen;
> +    if (S_ISDIR(mode)) {
> +        strbuf_append_string(&path, "/");
> +        buffer = NULL;
> +        size = 0;
> +    } else {
> +        buffer = read_sha1_file(sha1, type, &size);
> +        if (!buffer)
> +            die("cannot read %s", sha1_to_hex(sha1));
> +    }
> +
> +    write_entry(sha1, &path, mode, buffer, size);

Here occurs the memory leak that I've been talking about. buffer needs to be free'd.

> +
> +    return READ_TREE_RECURSIVE;
> +}
Previous: Junio C Hamano
Message 40 of 40 in “Add git-archive”
  1. 1/2 Add git-archiveFranck Bui-Huu, Sep 5, 2006
  2. Junio C HamanoSep 5, 2006
  3. Franck Bui-HuuSep 6, 2006
  4. Rene ScharfeSep 6, 2006
  5. Jakub NarebskiSep 6, 2006
  6. Rene ScharfeSep 8, 2006
  7. Junio C HamanoSep 6, 2006
  8. Franck Bui-HuuSep 7, 2006
  9. Junio C HamanoSep 7, 2006
  10. Franck Bui-HuuSep 7, 2006
  11. Junio C HamanoSep 7, 2006
  12. Add git-archive [take #2]Franck Bui-Huu, Sep 7, 2006
  13. 1/4 Add git-archiveFranck Bui-Huu, Sep 7, 2006
  14. Junio C HamanoSep 8, 2006
  15. Franck Bui-HuuSep 8, 2006
  16. Rene ScharfeSep 8, 2006
  17. Franck Bui-HuuSep 9, 2006
  18. Rene ScharfeSep 9, 2006
  19. Franck Bui-HuuSep 9, 2006
  20. 2/4 git-archive: wire up TAR format.Franck Bui-Huu, Sep 7, 2006
  21. Rene ScharfeSep 8, 2006
  22. Junio C HamanoSep 8, 2006
  23. Junio C HamanoSep 9, 2006
  24. Rene ScharfeSep 9, 2006
  25. Franck Bui-HuuSep 9, 2006
  26. Junio C HamanoSep 9, 2006
  27. Use xstrdup instead of strdup in builtin-{tar,zip}-tree.cRene Scharfe, Sep 10, 2006
  28. Franck Bui-HuuSep 9, 2006
  29. 3/4 git-archive: wire up ZIP format.Franck Bui-Huu, Sep 7, 2006
  30. 4/4 Add git-upload-archiveFranck Bui-Huu, Sep 7, 2006
  31. Franck Bui-HuuSep 7, 2006
  32. Junio C HamanoSep 8, 2006
  33. Franck Bui-HuuSep 8, 2006
  34. Jakub NarebskiSep 8, 2006
  35. Junio C HamanoSep 8, 2006
  36. Franck Bui-HuuSep 8, 2006
  37. Junio C HamanoSep 8, 2006
  38. Rene ScharfeSep 8, 2006
  39. Junio C HamanoSep 8, 2006
  40. Rene ScharfeSep 6, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.