git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-branch: be prepared for ref-logging

From
Junio C Hamano <junkio@cox.net>
Date
Feb 3, 2007, 19:50 UTC
Message-ID
<7vr6t73tsi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11705277471962-git-send-email-hjemli@gmail.com>
Lars Hjemli <hjemli@gmail.com> writes:
Show 9 quoted lines
> The test for reflog parameter to create_branch() should also have tested
> for log_all_ref_updates. But there is no good reason not to prepare a
> reflog message, so lets just do it.
>
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>
> Sorry, the previous patch was obviously no good, since it didn't honour
> the case where (reflog==1 && log_all_ref_updates==0)

Ah, I did not see your fix-up patch before I sent out my comments.

Funny thing is that I thought I fixed this already, but apparently I didn't. It could have been one of my "fixing in working tree, sending out a patch to the list for comments and then forgetting to apply it". Maybe not.

In any case, thanks for the fix.
Previous: Lars HjemliNext: Lars Hjemli
Message 6 of 11 in “fix use of sometimes uninitialized variable 'msg'”
  1. fix use of sometimes uninitialized variable 'msg'Michael Coleman, Feb 3, 2007
  2. fix uninitialized use of msg bufferMichael Coleman, Feb 3, 2007
  3. builtin-branch: be prepared for ref-loggingLars Hjemli, Feb 3, 2007
  4. Junio C HamanoFeb 3, 2007
  5. builtin-branch: be prepared for ref-loggingLars Hjemli, Feb 3, 2007
  6. Junio C HamanoFeb 3, 2007
  7. Lars HjemliFeb 3, 2007
  8. Junio C HamanoFeb 3, 2007
  9. Lars HjemliFeb 3, 2007
  10. Junio C HamanoFeb 3, 2007
  11. Mike ColemanFeb 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.