Re: [PATCH] builtin-branch: be prepared for ref-logging

From: Junio C Hamano <junkio@cox.net>
Date: Feb 3, 2007, 18:55 UTC
Message-ID: <7vzm7v5aw7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11705266492308-git-send-email-hjemli@gmail.com>

Lars Hjemli <hjemli@gmail.com> writes:

Show 10 quoted lines

> The test for reflog parameter to create_branch() should also have tested
> for log_all_ref_updates. But there is no good reason not to prepare a
> reflog message, so lets just do it.
>
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>
> If log_all_ref_updates==1 then the reflog will get an empty message with 
> your patch. That is better than using an uninitialized message, but I think
> it's still better to just prepare a proper message.

True, but don't you still need to set log_all_ref_updates while you call write_ref_sha1() for that ref in order to make sure that log_ref_write() sets O_CREAT in oflags?