From: Junio C Hamano <junkio@cox.net>
Date: Sat, 03 Feb 2007 19:50:05 GMT
Subject: Re: [PATCH] builtin-branch: be prepared for ref-logging
Message-ID: <7vr6t73tsi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11705277471962-git-send-email-hjemli@gmail.com>

Lars Hjemli <hjemli@gmail.com> writes:

> The test for reflog parameter to create_branch() should also have tested
> for log_all_ref_updates. But there is no good reason not to prepare a
> reflog message, so lets just do it.
>
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>
> Sorry, the previous patch was obviously no good, since it didn't honour
> the case where (reflog==1 && log_all_ref_updates==0)

Ah, I did not see your fix-up patch before I sent out my
comments.

Funny thing is that I thought I fixed this already, but
apparently I didn't.  It could have been one of my "fixing in
working tree, sending out a patch to the list for comments and
then forgetting to apply it".  Maybe not.

In any case, thanks for the fix.