Re: [PATCH] git-remote: support remotes with a dot in the name

From: Junio C Hamano <junkio@cox.net>
Date: Feb 21, 2007, 07:32 UTC
Message-ID: <7vr6skrmo9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070221021206.8onspw0840gcs8ck@webmail.spamcop.net>

Pavel Roskin <proski@gnu.org> writes:

Show 5 quoted lines

> I was thinking of something like
>
> [remote "wireless-2.6"]
> url = http://foo/bar
> url.push = ssh://foo/bar

Ahh.

I was not taking the above use case into account when I wrote that regexp, because I do not think we ever supported (nor were planning to ever support) names with dot at the third level.

> But I think it's quite unlikely to be named like that.

The second level ("wireless-2.6") is designed to be more lenient to accept wider "user level names" for branches, remotes, etc., but the third level is for variable names the programs use, and it is not the question of likely/unlikely, but more about how we (as the git system builders, not the end users) want to name our variables. So I do not think it is not such a big deal if we do not support "url.push" variable.

Show 5 quoted lines

>> But my Perl is rusty, so please double check it.
>
> The "(\S*?)" construct looks weird (you probably meant to use "(\S*)" for the
> remote name), but the rest is probably OK.  I'll send the "double-checked"
> patch tomorrow unless you beat me at that.

Actually I did mean to write "*?"; wasn't it how minimal match is written?