Re: [PATCH] git-remote: support remotes with a dot in the name

From: Pavel Roskin <proski@gnu.org>
Date: Feb 21, 2007, 05:46 UTC
Message-ID: <20070221004631.q4npyww808k88s0o@webmail.spamcop.net>
In-Reply-To: <7vwt2ct79x.fsf@assigned-by-dhcp.cox.net>

Quoting Junio C Hamano <junkio@cox.net>:

> I do not think we ever officially "supported" remotes with a dot
> in their names since $GIT_DIR/remotes/ or $GIT_DIR/branches
> days.

On the other hand, I've been tracking "wireless-2.6" for months without even realizing that the name could be a problem. It is only when I tried the new "git-remote update" that I noticed that it tries to update "wireless-2" and fails.

Show 11 quoted lines

> I do not strongly oppose to allowing it now, but I suspect this
> is probably less impact:
>
> 	if (/^remote\.(\S+?)\.([^.\s]+)\s+(.*)$/) {
>         	...
> 	}
>
> With this, we disallow whitespaces in remote names, but we leave
> the door open for supporting variables other than fetch and url
> by accepting the third token that matches any sequence of
> non-dot, non-whitespace letters.

It would be great as long as we don't use names with more than one dot after the remote name (e.g. remote.wireless-2.6.url.push), but if you think it's unlikely, I agree that your code is better.

-- Regards, Pavel Roskin