Re: [PATCH] git-remote: support remotes with a dot in the name

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 21, 2007, 07:29 UTC
Message-ID: <20070221072921.GB28152@spearce.org>
In-Reply-To: <20070221021206.8onspw0840gcs8ck@webmail.spamcop.net>

Pavel Roskin <proski@gnu.org> wrote:

Show 5 quoted lines

> I was thinking of something like
> 
> [remote "wireless-2.6"]
> url = http://foo/bar
> url.push = ssh://foo/bar

The key `url.push` is not a valid string in a config file.

> > But my Perl is rusty, so please double check it.

FWIW Junio's pattern looks OK to me.

> The "(\S*?)" construct looks weird (you probably meant to use "(\S*)" for the
> remote name), but the rest is probably OK.  I'll send the "double-checked"
> patch tomorrow unless you beat me at that.

The use of (\S+?) here is right. We want to be non-greedy in our matching of the remote name, as we don't want to overslurp and grab through the key name and part of the key value into the remote name by mistake, especially if the key value contained spaces.

-- 
Shawn.