Re: [PATCH 2/2] filter-branch.sh: support nearly proper tag name filtering

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2008, 05:49 UTC
Message-ID: <7vr6e01xja.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0803201812560.4124@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 11 quoted lines

> On Thu, 20 Mar 2008, Brandon Casey wrote:
>
>> Add support for creating a new tag object and retaining the tag message, 
>> author, and date when rewriting tags. The gpg signature, if one exists, 
>> will be stripped.
>> 
>> This adds nearly proper tag name filtering to filter-branch. Proper tag 
>> name filtering would include the ability to change the tagger, tag date, 
>> tag message, and _not_ strip a gpg signature if the tag did not change.
>
> I think such a change in semantics merits a new option.

It is a different story if the fix is a good one, or has room for improvement. For example, the sed script that knows what is on the first and second line and relies on that knowledge to use 1c...2c... looked very fragile to me.

However, at least to me, this looked like an attempt for a pure "fix".

If you tell filter-branch to filter a branch A and a tag T, as the command is advertised to rewrite positive refs that were given from the command line, isn't it natural to expect that the command would attempt its best effort to rewrite such a tag object?