Re: [PATCH 2/2] filter-branch.sh: support nearly proper tag name filtering

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Mar 20, 2008, 17:38 UTC
Message-ID: <47E2A10F.1010703@nrlssc.navy.mil>
In-Reply-To: <alpine.LSU.1.00.0803201812560.4124@racer.site>

Johannes Schindelin wrote:

Show 13 quoted lines

> Hi,
> 
> On Thu, 20 Mar 2008, Brandon Casey wrote:
> 
>> Add support for creating a new tag object and retaining the tag message, 
>> author, and date when rewriting tags. The gpg signature, if one exists, 
>> will be stripped.
>>
>> This adds nearly proper tag name filtering to filter-branch. Proper tag 
>> name filtering would include the ability to change the tagger, tag date, 
>> tag message, and _not_ strip a gpg signature if the tag did not change.
> 
> I think such a change in semantics merits a new option.

I had understood the current behavior to be a shortcoming rather than desirable behavior.

The change this patch introduces is not the stripping of the gpg signature, it is the new ability to _retain_ the properties of a tag object. Current behavior discards everything, including the signature.

If people expect the current behavior and would not welcome this new behavior, then maybe a new option is needed, but I'm not convinced yet. I'm thinking that maybe converting a tag object into a light-weight tag should be the special operation (if that is desirable).

-brandon