Re: [PATCH] filter-branch.sh: support nearly proper tag name filtering
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 25, 2008, 01:14 UTC
- Message-ID
- <7v63vbr4eq.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <47E8267D.5000405@nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
> I learned that the 'Q' command to sed is not portable, and most versions > of sed require a newline after 'c\' like commands.
Both true. If you want to be portable to esoteric ones (I suffered AIX while hacking on autoconf long time ago), sed is a bitch to get right.
What I meant with my earlier comment was that it would have been more robust if you did a sequence of:
s/type .*/type $newtype/
s/object .*/object $newobject/instead of relying on the order in the existing objects, but I should have been more explicit about c\ as well.