Re: [PATCH] send-email: Refuse to send cover-letter template subject

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2009, 16:06 UTC
Message-ID: <7vr5xp8mhw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200906121348.19103.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 14 quoted lines

> Thomas Rast wrote:
>> Junio C Hamano wrote:
>> > Thomas Rast <trast@student.ethz.ch> writes:
>> > 
>> > > Every so often, someone sends out an unedited cover-letter template.
>> > > Add a simple check to send-email that refuses to send if the subject
>> > > contains "*** SUBJECT HERE ***", with an option --force to override.
>> > 
>> > Good ;-).  More valuable to detect would be an empty "blurb" section
>> > (i.e. not "unedited *** BLURB HERE ***" string, but literally, there is
>> > nothing said in the message other than the shortstat).
> ...
> What do you want me to do about the patch?  Should I extend it so that
> it traps both "*** BLURB HERE ***" and "*** SUBJECT HERE ***"?

Oh, nothing.

I did not mean to say "if you do not add this unrelated thing, your patch is not acceptable." Please take my "oh I wish there is another feature to do this similar but different thing" as a hint for possible follow-up patches, and they do not necessarily have to be done by you but can be done by anybody, or for that matter they do not have to be done by anybody like this particular case where it turns out to be "why bother? it cannot be done sensibly and usefully".

Thanks, and sorry.  I'll try to be more explicit next time.