Re: [PATCH] send-email: Refuse to send cover-letter template subject

From: Thomas Rast <trast@student.ethz.ch>
Date: Jun 9, 2009, 08:19 UTC
Message-ID: <200906091019.11000.trast@student.ethz.ch>
In-Reply-To: <7v4ouqwa42.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 9 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
> 
> > Every so often, someone sends out an unedited cover-letter template.
> > Add a simple check to send-email that refuses to send if the subject
> > contains "*** SUBJECT HERE ***", with an option --force to override.
> 
> Good ;-).  More valuable to detect would be an empty "blurb" section
> (i.e. not "unedited *** BLURB HERE ***" string, but literally, there is
> nothing said in the message other than the shortstat).

Wouldn't that be AI complete? As in, whatever regex (or similar) you might cook up could probably be matched by *someone's* style of patch descriptions, and then it suddenly becomes rather hard to tell them apart.

I was really only trying to prevent the case where the user formatted several times in a row because he noticed mistakes in the patches, and forgot to re-edit the cover letter. At least that's how I once sent out one with a real description but the template subject.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch