Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 24, 2012, 04:57 UTC
Message-ID: <7vr4mgnj2v.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vk3sc2hx9.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> I needed something like this on top of it to get it pass t5800.
>
> diff --git a/git_remote_helpers/git/__init__.py b/git_remote_helpers/git/__init__.py
> index 776e891..5047fd4 100644
> --- a/git_remote_helpers/git/__init__.py
> +++ b/git_remote_helpers/git/__init__.py
> @@ -1,3 +1,5 @@
> +import sys
> +
>  if sys.hexversion < 0x02040000:
>      # The limiter is the subprocess module
>      sys.stderr.write("git_remote_helpers: requires Python 2.4 or later.")

Ping?  Is the above the best fix for the breakage?

If it weren't __init__, I'd silently squash it in, but the filename feels a bit more magic than the ordinary *.py files, so I was worried there may be some other rules involved what can and cannot go in to such a file, hence I've been waiting for an ack or alternatives.

Thanks.