Re: [PATCH] Python scripts audited for minimum compatible version and checks added.
- From
Manlio Perillo <manlio.perillo@gmail.com>
- Date
- Dec 21, 2012, 15:58 UTC
- Message-ID
- <50D4873A.6060501@gmail.com>
- In-Reply-To
- <20121220141855.05DAA44105@snark.thyrsus.com>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Il 20/12/2012 15:13, Eric S. Raymond ha scritto:
> Signed-off-by: Eric S. Raymond <esr@thyrsus.com> > ---
Just my two cents. Isn't it better to have some core Python support inside a "python/" directory in the git source tree (e.g. e simple python/git.py), and have *all* python code import that module?
Then you can impose a reasonable version limitation (e.g. Python >= 2.5) inside that module (and/or inside its setup.py file).
Another advantage is that the python/git.py module can contain some very base support for interfacing git plumbing commands, instead of having all internal (and external) modules reinventing the wheel.
I'm writing an external command for Git, and I do plan to write such a package, so that I don't have to reimplement all the base support in my command source code.
Regards Manlio -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlDUhzoACgkQscQJ24LbaUQFuQCfb6QgkJHdxQSEB7nLXMN8TSmI 6/IAn3svylllaIBQfZKf0lEzNBtZJQMK =Ar20 -----END PGP SIGNATURE-----