Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

From: Eric S. Raymond <esr@thyrsus.com>
Date: Dec 20, 2012, 15:02 UTC
Message-ID: <20121220150252.GA24387@thyrsus.com>
In-Reply-To: <20121220144813.GA27211@sigill.intra.peff.net>

Jeff King <peff@peff.net>:

Show 18 quoted lines

> On Thu, Dec 20, 2012 at 09:13:37AM -0500, Eric S. Raymond wrote:
> 
> > diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py
> > index bd24395..b55648f 100755
> > --- a/contrib/ciabot/ciabot.py
> > +++ b/contrib/ciabot/ciabot.py
> > @@ -50,6 +50,11 @@
> >  import os, sys, commands, socket, urllib
> >  from xml.sax.saxutils import escape
> >  
> > +if sys.hexversion < 0x02000000:
> > +	# The limiter is the xml.sax module
> > +        sys.stderr.write("import-zips.py: requires Python 2.0.0 or later.")
> > +        sys.exit(1)
> 
> Should the error message say ciabot.py?
> 
> -Peff

Gack. Yes. Thaty's what I get for cut-and-pasting too quickly. The information about xnml.sex is correct, though.

Want me to resubmit, or will you just patch it?

Note by the way that I still think the entire ciabot subtree (which is my code) should just be nuked. CIA is not coming back, wishful thinking on Ilkotech's web page notwithstanding.

-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>