git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}

From
Junio C Hamano <gitster@pobox.com>
Date
May 10, 2013, 17:34 UTC
Message-ID
<7vr4he20yu.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAPig+cSW39bnmKOeNDz0H5ZyNzPt3oCLnCUttaMJU9fGuKvJeQ@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 27 quoted lines
> On Fri, May 10, 2013 at 10:29 AM, Ramkumar Ramachandra
> <artagnon@gmail.com> wrote:
>> test-lib.sh already sets a sane GIT_AUTHOR_{NAME,EMAIL} for all test
>> scripts to use.  Don't unnecessarily duplicate the work.
>>
>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> ---
>>  t/t3400-rebase.sh | 4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
>> index b58fa1a..a7ca2f1 100755
>> --- a/t/t3400-rebase.sh
>> +++ b/t/t3400-rebase.sh
>> @@ -10,10 +10,6 @@ among other things.
>>  '
>>  . ./test-lib.sh
>>
>> -GIT_AUTHOR_NAME=author@name
>> -GIT_AUTHOR_EMAIL=bogus@email@address
>
> These values are intentionally bogus. Doesn't this change defeat the
> purpose of 43c2325 (am: use get_author_ident_from_commit instead of
> mailinfo when rebasing; 2010-06-16)?
>
>> -export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL
>> -

Then perhaps there needs an in-code comment before these three lines to explain why they are deliberately set to bogus values, no?

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 5 of 21 in “Trivial cleanups to t3400 (rebase)”
  1. 0/4 Trivial cleanups to t3400 (rebase)Ramkumar Ramachandra, May 10, 2013
  2. 1/4 t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}Ramkumar Ramachandra, May 10, 2013
  3. Eric SunshineMay 10, 2013
  4. Ramkumar RamachandraMay 10, 2013
  5. Junio C HamanoMay 10, 2013
  6. 2/4 t3400 (rebase): downcase a couple of test titlesRamkumar Ramachandra, May 10, 2013
  7. 3/4 t3400 (rebase): move lone statement into a testRamkumar Ramachandra, May 10, 2013
  8. 4/4 t4300 (rebase): don't unnecessarily set GIT_TRACERamkumar Ramachandra, May 10, 2013
  9. Junio C HamanoMay 10, 2013
  10. Ramkumar RamachandraMay 10, 2013
  11. Junio C HamanoMay 10, 2013
  12. Ramkumar RamachandraMay 10, 2013
  13. Junio C HamanoMay 10, 2013
  14. Ramkumar RamachandraMay 10, 2013
  15. Ramkumar RamachandraMay 10, 2013
  16. Jonathan NiederMay 10, 2013
  17. Ramkumar RamachandraMay 10, 2013
  18. Jonathan NiederMay 10, 2013
  19. Junio C HamanoMay 10, 2013
  20. Ramkumar RamachandraMay 11, 2013
  21. Jonathan NiederMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.