git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] t4300 (rebase): don't unnecessarily set GIT_TRACE

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 10, 2013, 14:29 UTC
Message-ID
<1368196178-5807-5-git-send-email-artagnon@gmail.com>
In-Reply-To
<1368196178-5807-1-git-send-email-artagnon@gmail.com>

A couple of tests execute 'git rebase' with GIT_TRACE set to 1, but this trace output is not used anywhere. Remove it, since it is not relevant to what we are testing.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 t/t3400-rebase.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh
index 0841a12..d0d9442 100755
--- a/t/t3400-rebase.sh
+++ b/t/t3400-rebase.sh
@@ -137,13 +137,13 @@ test_expect_success 'rebase a single mode change' '
 	test_chmod +x A &&
 	test_tick &&
 	git commit -m modechange &&
-	GIT_TRACE=1 git rebase master
+	git rebase master
 '
 
 test_expect_success 'rebase is not broken by diff.renames' '
 	test_config diff.renames copies &&
 	git checkout filemove &&
-	GIT_TRACE=1 git rebase force-3way
+	git rebase force-3way
 '
 
 test_expect_success 'setup: recover' '
-- 
1.8.3.rc1.52.gc14258d
Previous: Ramkumar RamachandraNext: Junio C Hamano
Message 8 of 21 in “Trivial cleanups to t3400 (rebase)”
  1. 0/4 Trivial cleanups to t3400 (rebase)Ramkumar Ramachandra, May 10, 2013
  2. 1/4 t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL}Ramkumar Ramachandra, May 10, 2013
  3. Eric SunshineMay 10, 2013
  4. Ramkumar RamachandraMay 10, 2013
  5. Junio C HamanoMay 10, 2013
  6. 2/4 t3400 (rebase): downcase a couple of test titlesRamkumar Ramachandra, May 10, 2013
  7. 3/4 t3400 (rebase): move lone statement into a testRamkumar Ramachandra, May 10, 2013
  8. 4/4 t4300 (rebase): don't unnecessarily set GIT_TRACERamkumar Ramachandra, May 10, 2013
  9. Junio C HamanoMay 10, 2013
  10. Ramkumar RamachandraMay 10, 2013
  11. Junio C HamanoMay 10, 2013
  12. Ramkumar RamachandraMay 10, 2013
  13. Junio C HamanoMay 10, 2013
  14. Ramkumar RamachandraMay 10, 2013
  15. Ramkumar RamachandraMay 10, 2013
  16. Jonathan NiederMay 10, 2013
  17. Ramkumar RamachandraMay 10, 2013
  18. Jonathan NiederMay 10, 2013
  19. Junio C HamanoMay 10, 2013
  20. Ramkumar RamachandraMay 11, 2013
  21. Jonathan NiederMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.