Re: [PATCH 4/4] t4300 (rebase): don't unnecessarily set GIT_TRACE

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2013, 17:51 UTC
Message-ID: <7vk3n6206h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0kLjf=m-_9PkXzxOpnpqfh-n004E0f7_mi-VL3SbYWFAg@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 5 quoted lines

> Junio C Hamano wrote:
>> Perhaps because this is a test about "rebase" and a typical debugger
>> does not want to trace other "git" things while debugging this?
>
> Okay, let's drop this 4-part series: it's too minor.

Why throw the baby with bathwater?

To me, most of them look like responses to valid issues, and that holds true even for [PATCH 1/4]. Even though your response may have been an incorrect one, the issue that triggered the response is still valid---the setting of these variables without explanation invites curiosities and a mistake similar to what you made in that patch.

If the patch were to consistently remove "GIT_TRACE=1" placed on "git rebase" from all test scripts that do not check the trace output consistently (i.e. 3400, 3402, and 7402), with a different justification, e.g. "whoever wants to debug a specific part of the test can add GIT_TRACE=1 before running the test with -v, but it should not be committed", the change would be very reasonable, I would think.