Re: [PATCH] [submodule] Add depth to submodule update

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 28, 2013, 22:51 UTC
Message-ID: <7vr4fllugy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51CDF819.9030308@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

Show 15 quoted lines

> Am 28.06.2013 20:44, schrieb Junio C Hamano:
>> Heiko Voigt <hvoigt@hvoigt.net> writes:
>> ... 
>>> Hmm, but does it have a --depth option for revisions? Maybe we should
>>> call it --clone-depth or --rev-depth to make it clear? --depth and
>>> --max-depth would be completely orthogonal but the name does not allow
>>> to distinguish them properly.
>> 
>> I do not have a strong opinion either way, but as you suggest, it
>> might be a good idea to call this new option --clone-depth to be
>> more specific.
>
> No strong opinion here either, but I'm leaning towards "--depth"
> because on one hand we already have the "--reference" option which
> is passed on to the clone command (and not "--clone-reference")...

OK, then "--depth" it is.

The points in your review on the last version with "--depth" (which I picked up and parked on 'pu') still need to be addressed, I think?