git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] [submodule] Add depth to submodule update

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Jun 25, 2013, 22:11 UTC
Message-ID
<20130625221132.GB4161@sandbox-ub>
In-Reply-To
<20130624224925.GC32270@paksenarrion.iveqy.com>
On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote:
> Used only when a clone is initialized. This is useful when the submodule(s)
> are huge and you're not really interested in anything but the latest commit.
> 
> Signed-off-by: Fredrik Gustafsson <iveqy@iveqy.com>

I this is a valid use case. But this option only makes sense when a submodule is newly cloned so I am not sure whether submodule update is the correct place. Let me think about this a little more. Since we do not have any extra command that initiates the clone this is probably the only place we can put this option. But at the moment it does not feel completely right.

Apart from that the code looks good. If the user does a checkout of a revision that was not fetched submodule update will error out the same way as if someone forgot to push his submodule changes. So that should not be a problem.

Cheers Heiko
Previous: Junio C HamanoNext: Fredrik Gustafsson
Message 4 of 14 in “[RFC] [submodule] Add depth to submodule update”
  1. Fredrik GustafssonJun 23, 2013
  2. [submodule] Add depth to submodule updateFredrik Gustafsson, Jun 24, 2013
  3. Junio C HamanoJun 25, 2013
  4. Heiko VoigtJun 25, 2013
  5. Fredrik GustafssonJun 26, 2013
  6. Junio C HamanoJun 26, 2013
  7. Jens LehmannJun 27, 2013
  8. Heiko VoigtJun 28, 2013
  9. Junio C HamanoJun 28, 2013
  10. Jens LehmannJun 28, 2013
  11. Junio C HamanoJun 28, 2013
  12. Fredrik GustafssonJun 28, 2013
  13. Junio C HamanoJun 30, 2013
  14. Junio C HamanoJun 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.