Re: [PATCH] [submodule] Add depth to submodule update
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 28, 2013, 18:44 UTC
- Message-ID
- <7vk3lenkhh.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20130628065001.GA2783@sandbox-ub>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 11 quoted lines
> On Thu, Jun 27, 2013 at 04:54:45PM +0200, Jens Lehmann wrote: > ... >> Me too thinks adding "--depth" to "update" makes sense (and I don't >> think that this pretty generic name will become a problem later in >> case someone wants to add a maximum recursion depth, as grep already >> uses "--max-depth" for the same purpose). > > Hmm, but does it have a --depth option for revisions? Maybe we should > call it --clone-depth or --rev-depth to make it clear? --depth and > --max-depth would be completely orthogonal but the name does not allow > to distinguish them properly.
I do not have a strong opinion either way, but as you suggest, it might be a good idea to call this new option --clone-depth to be more specific.